search

kuldeepkeshwar / filbert-js

A lightweight(~1kb) css-in-js framework
https://filbert-js.vercel.app/docs/introduction
MIT License
176 stars 9 forks source link

Background Image appending a semi colon? #68

Closed cjenaro closed 4 years ago

cjenaro commented 4 years ago

Hi there, so me again, apparently when importing an image in react and using the base64 iamge as background, at the end there is a : being added that breaks the image.

https://cad-overlay.netlify.app/

Here's the app, right under the div root, you should have a div with the background image that is not being set properly, if you want to check out my repo:

https://github.com/jenaro94/cad-overlay

If you inspect the css and remove that : the background image will show correctly.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.91. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

kuldeepkeshwar commented 4 years ago

@jenaro94 thanks for report this. This happened as @filbert-js/css-ast was tokenising css ruleset based on ; & ':' only.

cjenaro commented 4 years ago

Should updating the library fix this?

kuldeepkeshwar commented 4 years ago

fixed in @filbert-js/css-parser 0.0.7