kulek1 / guitar-tab-maker-issues

Public repository for issue tracking https://tab-maker.com
49 stars 9 forks source link

Export to PDF - Your Tablature is not valid. Please correct it and try again. #16

Closed pattrickrice closed 8 months ago

pattrickrice commented 8 months ago

Describe the bug A clear and concise description of what the bug is.

Error dialog appears when trying to export to PDF. Error below is found in the console.

index-TEKWnxS3.js:73 Error: Parse error on line 6:
...13/3 13/3 16/4 13/3 .16/4h 13/3 .16/4h 1
-----------------------^
Expecting 'EOF', 'OPTIONS', 'TABSTAVE', 'STAVE', 'VOICE', 'TEXT', 'NOTES', 'SLUR', '=', '[', ']', '|', ':', '(', 'NUMBER', 'h', '-', 's', 't', 'T', 'b', 'p', '^', '$', '!', '#', 'ABC', got '.'
    at Parser.parseError (vextab.js:47174:21)
    at Parser.parse (vextab.js:47241:22)
    at vextab../src/vextab.jison.exports.parse (vextab.js:47773:51)
    at VexTab.parse (vextab.js:46690:74)
    at oO (index-TEKWnxS3.js:299:103952)
    at fO (index-TEKWnxS3.js:305:52)
    at m (index-TEKWnxS3.js:309:15476)
    at index-TEKWnxS3.js:70:6984
    at Object.wv (index-TEKWnxS3.js:99:9855)
    at yv (index-TEKWnxS3.js:99:10009)
    at Sv (index-TEKWnxS3.js:99:10066)
    at W0 (index-TEKWnxS3.js:99:31446)
    at KQ (index-TEKWnxS3.js:99:31863)
    at index-TEKWnxS3.js:99:36776
    at oV (index-TEKWnxS3.js:102:36935)
    at uQ (index-TEKWnxS3.js:99:8991)
    at cg (index-TEKWnxS3.js:99:33150)
    at Rp (index-TEKWnxS3.js:99:17360)
    at Wv (index-TEKWnxS3.js:99:17144)
    at HTMLDivElement.r (index-TEKWnxS3.js:358:1426)

To Reproduce Steps to reproduce the behavior: I've included the export of the tab to TEXT which it exports successfully. project37.txt

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Screenshot 2024-01-14 at 12 28 09 PM

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

I actually don't need to export to PDF. I just need a way to print the tabs.

kulek1 commented 8 months ago

@pattrickrice thanks for the report! Given what you have provided, it seems to me that the second tablature you have created might be incorrect:

E|--------------------------------------------------------------------------------------
B|--------------------------------------------------------------------------------------
G|-16-16-13-13-16-16-13-13-16-16-13-13-16-16-13-13-----13-h--13-h--13-h--13-h-13----13--
D|-------------------------------------------------16----16----16----16----16----16-----
A|--------------------------------------------------------------------------------------
E|--------------------------------------------------------------------------------------

specifically this part:

Screenshot 2024-01-14 at 22 04 36

Can you attach a screenshot of that tablature to make sure I'm not missing anything?

pattrickrice commented 8 months ago

Here is a screenshot of that section.

Screenshot 2024-01-14 at 12 27 59 PM

I think I would be surprised that whether the section is "valid" or not would cause an error, especially since the export to text works fine? Validating the tab could make sense, but maybe highlighting the erroneous section would be useful.

kulek1 commented 8 months ago

@pattrickrice thanks! Correct me if I'm wrong, but hammer-on from 13 to 13 doesn't make sense and that's why the PDF doesn't work here. I'll think about adding a validation for invalid tabs.

Although your problem doesn't suggest a bug in the application, I have released a new version v3.5.0 which supports the "print" function from your browser. I hope you'll now be able to print your tabs :)

pattrickrice commented 8 months ago

Wow super appreciate the fast turn around on that! Yeah i was misusing the h, but thanks for considering the suggestion!