Cannot change settings (i.e. endpoint) in "classic" Jenkins

kuleuven / jenkins-mattermost-plugin

Jenkins plugin for Mattermost

MIT License

24 stars 46 forks source link

Cannot change settings (i.e. endpoint) in "classic" Jenkins #31

Closed Unpublished closed 5 years ago

Unpublished commented 5 years ago

Happens since https://github.com/kuleuven/jenkins-mattermost-plugin/commit/f8a52af1da1b64e9ad3eb51b5b84f66d7e139219

Workaround: Downgrade to 2.5.2.

jovandeginste commented 5 years ago

@ewelinawilkosz @ndeloof any thoughts?

ewelinawilkosz commented 5 years ago

that was a very trivial change, didn't expect to cause any trouble... will have a look

ewelinawilkosz commented 5 years ago

@jovandeginste is endpoint the only field you have trouble with?

jovandeginste commented 5 years ago

@Unpublished can you provide an answer? I'll see if I can reproduce, meanwhile

jovandeginste commented 5 years ago

@ewelinawilkosz I can reproduce: changing any item in the configuration is not persisted Talking about all of:

endpoint
channel
Icon to use
Build Server URL

ewelinawilkosz commented 5 years ago

thanks for checking so fast, I'll try to fix today afternoon, will keep you updated

ewelinawilkosz commented 5 years ago

fix on the way, PR with comment: https://github.com/jenkinsci/mattermost-plugin/pull/8

jovandeginste commented 5 years ago

@Unpublished v2.6.1 is released; can you provide feedback when you get a chance?

Unpublished commented 5 years ago

The issue is fixed, thank you both!

ewelinawilkosz commented 5 years ago

good to hear, sorry for the mess!

jovandeginste commented 5 years ago

@Unpublished thanks for reporting and feedback! @ewelinawilkosz I consider this a small issue, not a mess... Thanks for your contribution (again) and for your swift fix!