kuleuven / jenkins-mattermost-plugin

Jenkins plugin for Mattermost
MIT License
24 stars 46 forks source link

Mattermost dedicated proxy settings #34

Closed bartos closed 4 years ago

bartos commented 5 years ago

Would it be possible to add mattermost dedicated proxy settings? We have a mattermost instance in the internet, but whole CI/CD is located in corporate network. We can access this mattermost instance with setting up proxy in Jenkins, but that settings affects other things in Jenkins also.

Separate proxy settings in the mattermost-plugin section would do the job nicely, without having to reinvent the wheel and preparing custom solutions.

Regards, b.

mazerty commented 4 years ago

it would be really handy for us as well

environment variables seem to work but it requires the dns to resolve the mattermost server hostname, which is NOT required since it should be the proxy who resolve the names we are stuck here :(

bartos commented 4 years ago

@mazerty I've created a pull request. Please test if you can.

mazerty commented 4 years ago

hi ! i'm really sorry but i don't have access to this jenkins anymore so i can't test it besides, we went around this by using the http rest plugin hope you'll find someone else to help you test this :)