kuleuven / jenkins-mattermost-plugin

Jenkins plugin for Mattermost
MIT License
24 stars 46 forks source link

add custom proxy settings #42

Closed bartos closed 4 years ago

bartos commented 4 years ago

Adds a custom proxy settings in configuration. If checked, custom proxy values are used to access Mattermost endpoint. Otherwise global Jenkins proxy is used (if set).

Closes #34

Since this is my first attempt to a Jenkins so probably there might be a lot more to do. First of all I was little confused with the @DataBoundSetter anotations - not sure if i've used them corectly.

Second thing: i was wondering how to access the settings from within the publish method, I've end up with static method

private static MattermostNotifier.DescriptorImpl getServiceDescriptor()

that might not be the best solution.

Also I tried using <f:optionalBlock> instead of <f:advanced> in the Settings, but I failed. I may attempt to this one more time if you find current solution not sufficient.