kulkultech / open-source

http://open-source.kulkul.tech
24 stars 24 forks source link

Improve user interface by change font color in Duration and Time #65

Closed MuhammadAzka9 closed 3 years ago

MuhammadAzka9 commented 3 years ago

I think the user interface on the website of kulkul tech is less attractive so that it causes users to sometimes have difficulty understanding.

empeje commented 3 years ago

Hi @MuhammadAzka9 , thank you for creating your first issue.

I understand that our internship first page still needs improvement, but it is intentional so that our aspiring interns like you can help us fix it.

About your concern, what we can do differently to make our internship page more attractive? And what is the correlation of attractiveness in helping you understand the material?

MuhammadAzka9 commented 3 years ago

I mean at every step there is a note, in that note the font color and background are the same color, in my opinion it's not nice to look at

empeje commented 3 years ago

Could you please your concrete idea about how to make it better? Could you illustrate or create a Pull Request to change it?

MuhammadAzka9 commented 3 years ago

I've changed the font color in the Duration and time notes to make it look more attractive, please review

empeje commented 3 years ago

Could you please elaborate on why you want to change the colour to red in this PR (https://github.com/kulkultech/open-source/pull/80)?

We have established a pattern where the note has a blueish colour. See the image below for an example.

Screen Shot 2021-04-26 at 09 29 42
MuhammadAzka9 commented 3 years ago

Could you please elaborate on why you want to change the colour to red in this PR (#80)?

We have established a pattern where the note has a blueish colour. See the image below for an example.

Screen Shot 2021-04-26 at 09 29 42
MuhammadAzka9 commented 3 years ago

i want to change the colour of font to red in this PR #80 because it is an important note and also the color is not the same as the background

empeje commented 3 years ago

We already have the Blue background for notes, can you change it to that instead.

See here for an example https://github.com/kulkultech/open-source/issues/65#issuecomment-826511787

empeje commented 3 years ago

Solved in #80