http.request calls in http.py yield positional argument warnings

kulpa / google-api-python-client

Automatically exported from code.google.com/p/google-api-python-client

Other

0 stars 0 forks source link

http.request calls in http.py yield positional argument warnings #190

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

It's not clear to me which util.positional decorator is yielding warning 
messages for these requests to new_request (via http.request), but it appears 
that the method argument is not intended to be position-based. Thus the 
following lines in http.py should specify that argument by keyword:

727, 782, 1151

Original issue reported on code.google.com by yova...@google.com on 4 Sep 2012 at 8:36

GoogleCodeExporter commented 9 years ago

Code review sent: https://codereview.appspot.com/7856049/

Original comment by jcgregorio@google.com on 26 Mar 2013 at 2:14

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Try line 817-818 of apiclient.http

 817        resp, content = http.request(self.resumable_uri, 'PUT', 
 818                                     headers=headers) 

There should be a method='PUT' where the positional 'PUT' parameter is being, 
erm... positioned.  ;-)

Original comment by iwonbig...@gmail.com on 23 Sep 2013 at 8:56