search

kulvind3r / GamingGaiden

Gameplay Time Tracker for PC and Emulator games
GNU Affero General Public License v3.0
85 stars 3 forks source link

.bat blocks install if on C: #12

Closed MaridaConnoisseur closed 5 months ago

MaridaConnoisseur commented 5 months ago

Batch file checks if it is running on C drive, and blocks install if it is.

kulvind3r commented 5 months ago

Thanks for the input.

I am aware that this fix can be added and will do so when necessary in next release. Don't want to create a brand new release within 24 hours of a previous release.

I know how to add a check to validate if it is a C: drive, don't need a PR for that.

Besides... Users can have a different drive as their OS drive or another folder that they use can also be protected.

So just checking for C: drive is not full proof solution of avoiding a directory in need of higher privilege, Instruction will still stand valid.

kulvind3r commented 5 months ago

While doing further investigation i have tested the application from C drive, Program Files , User directory, and Desktop folder.

Application runs completely fine from all these locations and load the modules correctly without any exception or failures.

My earlier assumption that the failures experienced by some users when application is installed to C drive was wrong. There is nothing wrong with the app and it works fine even from any directory in C drive.

A stackoverflow user has posted facing a similar issue here https://stackoverflow.com/questions/41572933/an-object-at-the-specified-path-c-users-user1-name-does-not-exist

This has the exact same error as given in the stack trace shared by these users including the op for this PR.

The stackoverflow user found that the issue was caused by corrupted user profiles on these user's machines. Powershell scripts were perfectly fine.

as such... this is even more reason for not needing this Drive Check while installing, application runs completely fine from C drive.