kumabook / stickynotes

Sticky Notes is a webextension that enable browser to put sticky to web page.
http://kumabook.github.io/stickynotes/
39 stars 14 forks source link

Don't distribute dev dependencies #177

Open svandragt opened 8 months ago

svandragt commented 8 months ago

I noticed when inspecting my personal site that in the Debugger > Sources tab of the development tools of Firefox there was a node_modules and webpack entries. As my site doesn't use these I had a look at it's contents and it appears this plugin is the cause. Looking at your package.json it seems you're distributing all your dev dependencies to your users. You should review the whole list not just webpack.

This will slow down the performance of the app, open your users up to dev only security vulnerabilities and allow your users to debug your extension.

image

Thanks for an otherwise great browser extension!