kumahq / kuma-gui

🐻 A GUI built on Vue.js for use with Kuma.
https://kuma.io/
Apache License 2.0
38 stars 20 forks source link

feat(zones): move KDSSubscriptions to use a table/summary #2664

Open johncowen opened 1 week ago

johncowen commented 1 week ago

Changes Zone Subscriptions only to use a table/summary view/interaction.

We decided that there would be far more space to show things if we used our common table/summary panel pattern instead of the accordion where there is very little space to show things:

Screenshot 2024-06-20 at 12 37 34

Screenshot 2024-06-20 at 12 37 44

See:


Questions:

  1. Do we want to show the Subscription YAML, the Subscription JSON config, or both?
  2. If we want to show both, should we add a separate [YAML] tab or use the Structured/YAML dropdown?

Note:

I'm guessing we'll want the same layout for DPP subscriptions, I plan to do this as a follow up and there will some changes made on top of here to make the panel work in both places.

netlify[bot] commented 1 week ago

Deploy Preview for kuma-gui ready!

Name Link
Latest commit f3c2558b576644ab968e78abb79d4a5786010548
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/668524d0b1390b0008c0b88f
Deploy Preview https://deploy-preview-2664--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

johncowen commented 6 days ago
  1. Do we want to show the Subscription YAML, the Subscription JSON config, or both?
  2. If we want to show both, should we add a separate [YAML] tab or use the Structured/YAML dropdown?

I figured we probably don't want to show the YAML, its not like you'd want to use it for anything. If that incorrect we can always add as a follow up.