kumahq / kuma-gui

🐻 A GUI built on Vue.js for use with Kuma.
https://kuma.io/
Apache License 2.0
38 stars 20 forks source link

chore: change netlify script to use Makefile #2707

Open johncowen opened 4 days ago

johncowen commented 4 days ago

Back in https://github.com/kumahq/kuma-gui/pull/2691 we moved all our dev scripts to a Makefile and noted:

Once we've merged this we can update this 'hook' in the Netlify web GUI to use the make file instead, we can then PR one last PR to remove this last package script.

I kinda forgot that we are using the netify.toml file instead of the web GUI, so I could have probably done this in the above PR but 🤷

As long as the preview site is being deployed here, then it should be fine (seems like it is to me)

I also updated related docs in CONTRIBUTING.md

netlify[bot] commented 4 days ago

Deploy Preview for kuma-gui ready!

Name Link
Latest commit 93b7d62e063448a97f22e02cf55133f3bff34fb9
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/667e9fb14810400008a895d0
Deploy Preview https://deploy-preview-2707--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.