kumahq / kuma-gui

🐻 A GUI built on Vue.js for use with Kuma.
https://kuma.io/
Apache License 2.0
39 stars 22 forks source link

Add `make lint/gherkin` to lint-staged #2763

Open johncowen opened 4 months ago

johncowen commented 4 months ago

What happened?

In https://github.com/kumahq/kuma-gui/pull/2742 I noted:

  • a make lint/gherkin to lint our .feature file tests. Ideally this would also be on a pre-commit hook, but for some reason when using it in the hook I got a SIGPIPE error, so I can follow up at a later date once I figure out why it does that.

Just making an issue to track the above.

We should be able to add something like:

  "*.feature": "make lint/gherkin"

to .lintstagedrc.json and have it automatically lint/format everybodys feature files.

Note, from the lint-staged docs:

So, considering you did git add file1.ext file2.ext, lint-staged will run the following command: your-cmd file1.ext file2.ext

i.e. it might be easier lint/format at all files by default, but only take the specified files if they are specified.

github-actions[bot] commented 1 month ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.