search

kumahq / kuma-gui

🐻 A GUI built on Vue.js for use with Kuma.
https://kuma.io/
Apache License 2.0
39 stars 22 forks source link

fix: remove decorative attribute from all icons to fix tooltipping #3175

Closed johncowen closed 1 week ago

johncowen commented 1 week ago

Hardcodes decorative="false" in order to guarantee that @kong/icons show (kong/icons PR that introduced the issue)

Not totally sure how to go about resolving the issue as yet, ideally I'd like to use CSS for all our icons as all icons by their very nature are "decorative". Once we've decided exactly what to do we can revisit this. In the meantime this fix resolves things for our users whilst dodging/avoiding any issues over implementation.

netlify[bot] commented 1 week ago

Deploy Preview for kuma-gui ready!

Name Link
Latest commit 7269de835d3002a0ef48195365eac966115506a3
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/6734e45b56341900083640c4
Deploy Preview https://deploy-preview-3175--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.