search

kumahq / kuma-gui

🐻 A GUI built on Vue.js for use with Kuma.
https://kuma.io/
Apache License 2.0
39 stars 22 forks source link

fix(ci): correct paths for SBOM moving #3179

Closed johncowen closed 1 week ago

johncowen commented 1 week ago

Follow up of https://github.com/kumahq/kuma-gui/pull/3176

The above PR moved files around quite a bit, and in doing so we didn't update the paths correctly for the SBOM moving around when we do a "release" to kuma.

GH Actions still run in root, but I changed all of the run: GHActions to have a different working directory in order to be able to run our make targets easier. Re-looking at the script in this PR, this means the SBOM reports are in root, but we checkout kuma into /packages/kuma-gui/main-application instead of what it used to be /main-application, this means we need to go 2 directories extra up (kuma-gui and packages) to get to root.

Unfortunately this is a bit hard to test as its not yet in the Makefile (I moved most of the CI scripts to our Makefile a while back so we could test them easier), just I was unfamiliar with this bit so unfortunately left it as is 😬 . Pretty sure this is good, but we'll only know on merge 🤞 😅 . I think my thinking is correct (see above explanation)

2 improvements I'd like to make in the future at somepoint:

  1. Checkout kuma at / - thats cleaner now we have workspaces
  2. Move this mv-y cp-y stuff into our Makefile so its easier to test outside of GH actions, and probably refine it a little.
netlify[bot] commented 1 week ago

Deploy Preview for kuma-gui ready!

Name Link
Latest commit 84c04da84e7721806e819a0df07f8f9f07c45c59
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/6734b37aca60020008e6965c
Deploy Preview https://deploy-preview-3179--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.