search

kumahq / kuma-gui

🐻 A GUI built on Vue.js for use with Kuma.
https://kuma.io/
Apache License 2.0
39 stars 22 forks source link

chore: adds new @kumahq/config module to house shareable config #3184

Closed johncowen closed 1 week ago

johncowen commented 1 week ago

Creates and moves a bunch of tooling config files into a new @kumahq/config module.

  1. eslint config
  2. stylelint config
  3. Cypress config
  4. a CI script that we use for sharding our tests to feed to Cypress so we can run them in parallel.

Couple of other things:

  1. I noticed a docgen.config file that we no longer use/need so I deleted that here also.
  2. I tried to be intentional with the new @kumahq/config/package.json dependencies. i.e. depend on the things it uses unless the host app also uses it (in which case use a peerDependency). I'm not totally sure if it matters in the grand scheme of things, but even if a tiny detail does matter it will be good to be intentional/correct about what we want to convey here. As a consequence of this a load of dev: trues where removed form our package-lock.json. I don't think this matters too much but thought I'd mention in case.
netlify[bot] commented 1 week ago

Deploy Preview for kuma-gui ready!

Name Link
Latest commit 7aeabf66e64a611d6040f1535365e4000779c8b4
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/6735f66429ed330008cc64cf
Deploy Preview https://deploy-preview-3184--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

johncowen commented 1 week ago

I think we need to specify more dependencies in the config/package.json and if we don't use them in kuma-gui code remove them respectively from kuma-gui/package.json 🤔

@badeball/cypress-cucumber-preprocessor eslint plugins stylelint plugins

I think I saw that @badeball/cypress-cucumber-preprocessor is ued elsewhere, but let me double check. But we should definitely move the eslint and stylelint ones over, let me look at that 👍

johncowen commented 1 week ago

I made a few tiny tweaks to the dependencies in that last commit (also fixed the tsconfig with the minimum I could that gave me no squiggly lines). lmk what you think!