search

kumahq / kuma-gui

🐻 A GUI built on Vue.js for use with Kuma.
https://kuma.io/
Apache License 2.0
39 stars 22 forks source link

fix(dataplanes): Fix margins on inbound cards in dataplane overview #3190

Closed johncowen closed 1 week ago

johncowen commented 1 week ago

I've used XLayout to do this and added a small variant, (fyi: we also have/had a .stack-small previously) Wanted to note I'm still ever so slightly cautious about XLayout (and the component first approach) https://github.com/kumahq/kuma-gui/pull/3092#issuecomment-2450324907, happy enough with it to use it to fix this though:

See left-hand inbound top/bottom margins:

Before

Screenshot 2024-11-18 at 09 12 08

After

Screenshot 2024-11-18 at 09 11 55

P.S. Be sure to use GHs hide whitespace option when reviewing:

Screenshot 2024-11-18 at 09 31 33

netlify[bot] commented 1 week ago

Deploy Preview for kuma-gui ready!

Name Link
Latest commit 51e4f9ae32213ed4e1a9de395aa695dc8ea4ba1f
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/673b04c777d5ce0008bbf754
Deploy Preview https://deploy-preview-3190--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.