search

kumahq / kuma-website

🐻 The official website for Kuma, the control plane for modern service connectivity.
https://kuma.io
Apache License 2.0
104 stars 87 forks source link

there's 2 assets directory which one should be removed #1597

Closed lahabana closed 7 months ago

lahabana commented 7 months ago

What happened?

There's: https://github.com/kumahq/kuma-website/tree/master/app/_assets and https://github.com/kumahq/kuma-website/tree/master/app/assets .

When working on https://github.com/kumahq/kuma-website/pull/1595 /app/assets was the right one but is this always the case?

jakubdyszkiewicz commented 7 months ago

@fabianrbz can you help with it? Thanks!

fabianrbz commented 7 months ago

app/_assets is meant for assets handled via vite.js (concatenation, compression, etc., so styles and javascript) app/assets acts as a public folder, so everything else goes here.

Looks like images are duplicated, we can remove app/_assets/images.