`installer.sh` should only consider commits that are first ancestors of the current `master`

kumahq / kuma-website

🐻 The official website for Kuma, the control plane for modern service connectivity.

https://kuma.io

Apache License 2.0

104 stars 87 forks source link

`installer.sh` should only consider commits that are first ancestors of the current `master` #1668

Closed michaelbeaumont closed 6 months ago

michaelbeaumont commented 7 months ago

Description

In the presence of merge commits, installer.sh will sometimes choose a commit from a PR branch that has been merged into master as the current preview version because:

it's in the history returned by the GraphQL API
it has a "green" status.

It should only consider commits that are first ancestors of the current master commit.

lahabana commented 6 months ago

IIUC this https://github.com/kumahq/kuma-website/pull/1710 fixes this issue.

michaelbeaumont commented 6 months ago

Yeah presumably gh run list doesn't return runs for commits on PR branches