kumahq / kuma-website

🐻 The official website for Kuma, the control plane for modern service connectivity.
https://kuma.io
Apache License 2.0
104 stars 86 forks source link

feat(upgrade): embed upgrade.md in docs #1706

Closed lahabana closed 3 months ago

lahabana commented 3 months ago

Fix #1535

<Explain your change!>

Did you sign your commit? Instructions

Have you read Contributing guidelines?

netlify[bot] commented 3 months ago

Deploy Preview for kuma ready!

Name Link
Latest commit bb005d24b2a751769dc40b1f707cb7e919a834d5
Latest deploy log https://app.netlify.com/sites/kuma/deploys/6613f88bfd764700089e7cfd
Deploy Preview https://deploy-preview-1706--kuma.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 93 (🔴 down 3 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

slonka commented 3 months ago

Rendered: https://deploy-preview-1706--kuma.netlify.app/docs/2.6.x/production/upgrades-tuning/upgrade-notes/

also some links are broken, should we disable link checker on this page?

lahabana commented 3 months ago

also some links are broken, should we disable link checker on this page?

I think we'd be better off fixing the links.

For the variable the UPGRADE pages are different between Kuma and KM and the one from KM will link to the Kuma docs (see: https://github.com/Kong/kong-mesh/blob/master/UPGRADE.md). It was an easy low effort change. In the future we may want to make these pages better but at least now we have this info on the docs website (perfect is the enemy of good :) )

lahabana commented 3 months ago

This should fix the links: https://github.com/kumahq/kuma/pull/9835

slonka commented 3 months ago

CoreDNS website timed out on the last link check and there is a problem with GH anchor that was fixed in main. Let's see if merge fixes it.

slonka commented 3 months ago

For the links issue: https://github.com/kumahq/kuma-website/pull/1712/files