kumahq / kuma-website

🐻 The official website for Kuma, the control plane for modern service connectivity.
https://kuma.io
Apache License 2.0
104 stars 87 forks source link

fix(docs): ensure getting started links have a return between them #1743

Closed johncowen closed 2 months ago

johncowen commented 2 months ago

Looks like there is some strange markdown behaviour with if_version.

This PR just amends one problem, but doesn't solve whatever the issue is. Happy to close if someone has a better solution.

Before

Screenshot 2024-04-15 at 16 19 50

After

Screenshot 2024-04-15 at 16 19 36

netlify[bot] commented 2 months ago

Deploy Preview for kuma ready!

Name Link
Latest commit 28dbe53e33fab162d6e0df072f1ee5d996ec4cfa
Latest deploy log https://app.netlify.com/sites/kuma/deploys/661e175e9acc180008b97db4
Deploy Preview https://deploy-preview-1743--kuma.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 94 (🟢 up 8 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

slonka commented 2 months ago

Still renders the wrong way in 2.1:

image

https://deploy-preview-1743--kuma.netlify.app/docs/2.1.x/

slonka commented 2 months ago

FYI @fabianrbz xrel: https://github.com/Kong/jekyll-generator-single-source/pull/16

slonka commented 2 months ago

@johncowen - added a newline to your PR so it renders correctly in older versions