search

kumahq / kuma-website

🐻 The official website for Kuma, the control plane for modern service connectivity.
https://kuma.io
Apache License 2.0
104 stars 87 forks source link

fix(guides): review comments #1750

Closed lobkovilya closed 5 months ago

lobkovilya commented 5 months ago

Review comments for https://github.com/kumahq/kuma-website/pull/1749 appeared after the guide was merged. This is PR to resolve them.

netlify[bot] commented 5 months ago

Deploy Preview for kuma ready!

Name Link
Latest commit 94cbc8916a29adecf1e4c80c373f111bce01557c
Latest deploy log https://app.netlify.com/sites/kuma/deploys/661fe029aefbd10009245a74
Deploy Preview https://deploy-preview-1750--kuma.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 89 (🔴 down 6 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

slonka commented 5 months ago

I think there were a bit more comments in my review. We can chat about this on slack / zoom if you want to.

lobkovilya commented 5 months ago

yeah I know, I'm resolving them as I'm progressing here :)