kumahq / kuma-website

🐻 The official website for Kuma, the control plane for modern service connectivity.
https://kuma.io
Apache License 2.0
104 stars 87 forks source link

chore: install netlify-cli in project instead of globally #1772

Closed kleinfreund closed 2 months ago

kleinfreund commented 2 months ago

Install the netlify-cli package in the project instead of globally.

Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com

Note: the packages in package.json are very outdated. It doesn’t look like we’re using Dependabot here.

netlify[bot] commented 2 months ago

Deploy Preview for kuma ready!

Name Link
Latest commit 5c4bffc0c54f2d80538148295f345d34d4dfa519
Latest deploy log https://app.netlify.com/sites/kuma/deploys/66291ca552e58300080a4b50
Deploy Preview https://deploy-preview-1772--kuma.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 91 (🔴 down 4 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

johncowen commented 2 months ago

Oh actually, could you have a look and see where else netlify is mentioned in the project? I think there are a couple of other places that should now use make serve or yarn dev

kleinfreund commented 2 months ago

Oh actually, could you have a look and see where else netlify is mentioned in the project? I think there are a couple of other places that should now use make serve or yarn dev

I did and I could only find this one instance. Have I missed any that you know of?

kleinfreund commented 2 months ago

@johncowen just pinging you in case you missed this. If you don’t know of any more instances that I haven’t found, I’ll merge this in a while.

johncowen commented 2 months ago

Does the one in the Procfile need changing?

kleinfreund commented 2 months ago

Does the one in the Procfile need changing?

Ah, interesting. I didn’t find this because I’ve already had the netlify line removed for a long time locally (I needed that for some reason to workaround some issue) and so didn’t consider it at all. I’ve updated it now.

johncowen commented 2 months ago

Ok cool, can you ping someone else to check this real quick, the JS here is fine by me, but I'm not totally sure about the Procfile and what its used for etc (especially seeing as you didn't need it locally)

kleinfreund commented 2 months ago

Ok cool, can you ping someone else to check this real quick, the JS here is fine by me, but I'm not totally sure about the Procfile and what its used for etc (especially seeing as you didn't need it locally)

@fabianrbz Could you have a look at this, please?

johncowen commented 2 months ago

thanks @fabianrbz 👍