search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.6k stars 332 forks source link

Test flagger with GatewayAPI and fix if anything is broken. #10657

Open slonka opened 2 months ago

slonka commented 2 months ago

What happened?

I think there are three problems with it:

  1. This does not work https://github.com/fluxcd/flagger/blob/133fdecf56b2983f69cf06cbdeb372f988d89343/docs/gitbook/tutorials/kuma-progressive-delivery.md?plain=1#L34 it should be kubectl label namespace test kuma.io/sidecar-injection=enabled otherwise pods to not have sidecars
  2. Default traffic permission is missing
apiVersion: kuma.io/v1alpha1
kind: TrafficPermission
mesh: default
metadata:
  name: allow-all-traffic
spec:
  sources:
    - match:
        kuma.io/service: '*'
  destinations:
    - match:
        kuma.io/service: '*'

thats why load tester can't access the podinfo service

  1. Flagger integration should be using MeshHTTPRoute

FYI @aryan9600

aryan9600 commented 1 month ago

steps 1 and 2 were addressed and released in https://github.com/fluxcd/flagger/releases/tag/v1.38.0

do you think we should migrate the integration to use MeshHTTPRoute or just instruct users to use Gateway API instead?

slonka commented 1 month ago

I think we agreed on the triage that it should use MeshHTTPRoute. Let me put it back to needs-information and we'll get back to you on this on Monday.

slonka commented 1 month ago

triage: let's deprecate the existing one and use Gateway API

slonka commented 1 month ago

triage: let's figure what works and what doesn't with Gateway API