search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.67k stars 333 forks source link

fix(controller): include services that have pods labled injection as part of mesh #12005

Closed jijiechen closed 1 week ago

jijiechen commented 1 week ago

Motivation

Improve reconciler of service controller

Implementation information

Detect if there is at least one pods of the service is labeled "kuma.io/sidecar-injection=enabled"

Supporting documentation

fixes https://github.com/kumahq/kuma/issues/11994

jijiechen commented 1 week ago

@lahabana @lukidzi WDYT? The current behaviour is not aligning to what we say in the doc and now it's requested by an actual user.

lahabana commented 1 week ago

I agree with Mike we're trying to part with this dependency. Folks should either label their entire namespace or all entities independently

jijiechen commented 1 week ago

As per triage, we don't update the behaviour in Kuma but update the doc website, so closing this PR. xref: https://github.com/kumahq/kuma/issues/11994#issuecomment-2470833410