Update references to deprecated protobuf lib

[parkanzky]

What happened?

Kuma code imports github.com/golang/protobuf/proto in a number of places. This package is deprecated in favor of google.golang.org/protobuf/proto. Should update everything to recommended package.

Unfortunately, the two packages are not compatible, so need to update all dependencies of any changed module at the same time.

[jpeach]

I think the main blocker is the generated Envoy protobufs, https://github.com/envoyproxy/go-control-plane/issues/524.

[github-actions[bot]]

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

[github-actions[bot]]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions[bot]]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions[bot]]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions[bot]]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[lukidzi]

Looks like there is one more place: https://github.com/kumahq/kuma/blob/master/pkg/plugins/policies/meshloadbalancingstrategy/plugin/xds/lbconfigurer.go#L5

[github-actions[bot]]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions[bot]]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[mmorel-35]

Hi ! Just to let you know that latest versions of cncf/xds and envoyproxy/go-control-plane don’t rely on old protobuf library anymore

[Icarus9913]

on the way

[mmorel-35]

Finally ! That was such a long way to go 😅! Through xds, envoy, go-control-plane ! I learned Bazel on the way 🥳

[Icarus9913]

Unfortunatlly, the latest v0.12.0 go-control-plane still use golang/protobuf. https://github.com/envoyproxy/go-control-plane/blob/989e83d4a05c74448fdc72e5a67df5529387c021/go.mod#L9

I'll do this migration once our dependency implemented it.

[mmorel-35]

The latest still supports v1 protobuf but the main branch doesn't, see https://github.com/envoyproxy/go-control-plane/blob/main/go.mod

[Icarus9913]

The latest still supports v1 protobuf but the main branch doesn't, see https://github.com/envoyproxy/go-control-plane/blob/main/go.mod

The main branch still include the github.com/golang/protobuf v1.5.4

https://github.com/envoyproxy/go-control-plane/blob/108116100bc16c91f49cd50d4b09495471c711c2/go.mod#L24

[mmorel-35]

Yes but that's not a direct dependency 😅.

[Icarus9913]

Yes but that's not a direct dependency 😅.

Oh, you're right. I gonna get a try with the next go-control-plane version.