search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.68k stars 334 forks source link

MeshProxyPatch error does not help debugging the issue #4785

Open slonka opened 2 years ago

slonka commented 2 years ago

What happened?

Error like this:

# [proxytemplates.kuma.io](http://proxytemplates.kuma.io/) "test-abc" was not valid:
# * spec.conf.modifications[1].httpFilter.value: native Envoy resource is not valid: invalid character 'a' in literal null (expecting 'u')

Does not help fixing the issue. Maybe this could be improved. The error message seems to come from jsonpb - not sure if we can do anything about this.

Side note: reported via slack.

jakubdyszkiewicz commented 2 years ago

Triage: ideally we would like to have more descriptive message with diff and place that is wrong. If we cannot do this in a reasonable time add "troubleshooting" in ProxyTemplate docs.

github-actions[bot] commented 2 years ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

lahabana commented 1 year ago

@jakubdyszkiewicz how's this in MeshPorxyPatch?

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

lahabana commented 1 year ago

I think we should check if it's better with MeshProxyPatch. If it is we should address this in MeshProxyPatch, if it isn't we should just close this issue

jakubdyszkiewicz commented 1 year ago

Triage: it's the same with MeshProxyPatch

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 9 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

slonka commented 9 months ago

@lahabana - as stated by @jakubdyszkiewicz it's the same in MeshProxyPatch - please prioritise this if you still think it's relevant

zd9KgA commented 9 months ago

Hi @slonka,

I'm still using my work-around to cope with https://github.com/kumahq/kuma/issues/4720, which is okay for the time being. For my understanding the adoptions of https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/ will fundamentally resolve my issues related the handling of graceful shutdown. I'd rather wait for this than to encourage you spending further effort in resolving the issue within the current setup.

slonka commented 9 months ago

Hi @zd9KgA - I linked to the wrong comment, this issue is unrelated. Yes https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/ - will resolve the issues.

github-actions[bot] commented 6 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 3 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 1 week ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.