search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.66k stars 333 forks source link

Refactor `pkg/core/xds.Proxy` #5124

Closed michaelbeaumont closed 3 months ago

michaelbeaumont commented 2 years ago

Description

At the moment it's a struct with a bunch of info that may or may not be present. We should make it more explicit what kind of proxy we're dealing with Dataplane (Gateway? Builtin Gateway?), ZoneIngress/ZoneEgress to make it easier to understand what cases need to be handled when dealing with a Proxy for generation.

lahabana commented 2 years ago

Should this be a method is dataplane_helpers.go ? That's where we already have things like: IsDelegatedGateway or IsBuiltinGateway

lahabana commented 2 years ago

3873 is a little related

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 9 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 3 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

michaelbeaumont commented 3 months ago

Not worth keeping this issue around