kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.63k stars 331 forks source link

Kuma helm not supporting stringList in the controlPlane.globalZoneSyncService.annotations #5138

Open parjun8840 opened 1 year ago

parjun8840 commented 1 year ago

What happened?

While specifying the CIDR's as a stringList in annotations for Kuma service I get error- Config used:

set {
    name  = "controlPlane.globalZoneSyncService.annotations.service\\.beta\\.kubernetes\\.io/load-balancer-source-ranges"
    value = "3.115.254.X/32, 52.196.108.X/32"
  }

Error: Error: failed parsing key "controlPlane.globalZoneSyncService.annotations.service\\.beta\\.kubernetes\\.io/load-balancer-source-ranges" with value 3.115.254.X/32, 52.196.108.X/32, key map " 52" has no value

Snippet of chart used:

repository = "https://kumahq.github.io/charts/" chart = "kuma" namespace = "kuma-system" version = "1.8.0" set { name = "controlPlane.globalZoneSyncService.annotations.service\.beta\.kubernetes\.io/load-balancer-source-ranges" value = "3.115.254.X/32, 52.196.108.X/32" }

As per the AWS documentation the NLB supports multiple CIDR's access to the application through "Annotation- [service.beta.kubernetes.io/load-balancer-source-ranges]" https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/guide/service/annotations/#:~:text=Notes-,service.beta.kubernetes.io/load%2Dbalancer%2Dsource%2Dranges,-stringList.

And for my use case I need multiple "/32" CIDR's to be allowed.

Other scenarios for better clarification of the issue:

  1. Manually editing the service once created with Kubectl: It works.....

apiVersion: v1 kind: Service metadata: annotations: meta.helm.sh/release-name: kuma-platform meta.helm.sh/release-namespace: kuma-system service.beta.kubernetes.io/aws-load-balancer-type: nlb service.beta.kubernetes.io/load-balancer-source-ranges: 52.192.156.X/32,3.115.254.X/32,10.10.10.10/32

  1. Specifying a single CIDR as a string: It works

    Specifying a single CIDR works even with Kuma helm chart- set { name = "controlPlane.globalZoneSyncService.annotations.service\.beta\.kubernetes\.io/load-balancer-source-ranges" value = "52.192.156.X/32" }

jakubdyszkiewicz commented 1 year ago

Triage: let's try to set this using HELM values or set and see if this is a problem with HELM chart itself

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

bartsmykla commented 1 year ago

It seems still to be an issue:

kumactl install control-plane --set 'controlPlane.globalZoneSyncService.annotations.service\\.beta\\.kubernetes\\.io/load-balancer-source-ranges=3.115.254.X/32, 52.196.108.X/32' | kubectl apply -f-
# Error: failed parsing --set data: key "X/32" has no value
# error: no objects passed to apply

kumactl install control-plane --set 'controlPlane.globalZoneSyncService.annotations.service\\.beta\\.kubernetes\\.io/load-balancer-source-ranges=3.115.254.X/32,52.196.108.X/32' | kubectl apply -f-
# Error: failed parsing --set data: key "X/32" has no value
# error: no objects passed to apply

kumactl install control-plane --set 'controlPlane.globalZoneSyncService.annotations.service\\.beta\\.kubernetes\\.io/load-balancer-source-ranges="3.115.254.X/32,52.196.108.X/32"' | kubectl apply -f-
# Error: failed parsing --set data: key "X/32\"" has no value
# error: no objects passed to apply
github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 9 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 6 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 3 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 2 weeks ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

slonka commented 2 weeks ago

Still the case