search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.66k stars 333 forks source link

don't use tmp dir for sockets in Dataplane #7268

Open lahabana opened 1 year ago

lahabana commented 1 year ago

It's a little strange to use tmp for storing sockets etc. We may want to do something better.

Originally posted by @jakubdyszkiewicz in https://github.com/kumahq/kuma/pull/7218#pullrequestreview-1532631235

jakubdyszkiewicz commented 1 year ago

Triage: we have workdir concept for kuma-cp. We should do something similar for kuma-dp. Let's also make sure that both workdirs do not clash with each other.

github-actions[bot] commented 1 year ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 9 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

jakubdyszkiewicz commented 9 months ago

Triage: we now have a workDir. We could do a migration of sockets to this work dir.

github-actions[bot] commented 2 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

jakubdyszkiewicz commented 2 months ago

Triage: is it still the case?

lukidzi commented 2 weeks ago

It seems we don't use tmpDir by the default https://github.com/kumahq/kuma/blob/master/app/kuma-dp/cmd/run.go#L107 only once ConfigDir is empty. https://github.com/kumahq/kuma/pull/10364/files

github-actions[bot] commented 2 weeks ago

Removing closed state labels due to the issue being reopened.

lukidzi commented 2 weeks ago

We don't currently provide a default path. Without a default path, we still use tempDir. We should set a default path for kuma-dp, similar to how we did for kuma-cp.