search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.68k stars 334 forks source link

NetworkAttachmentDefinitions only created when Namespace is labelled for sidecar-injection #7741

Open gperanich opened 1 year ago

gperanich commented 1 year ago

What happened?

Description

Using OpenShift 4.12

In our Mesh deployment, users can selectively bringing services into the mesh via labeling Deployments, as if they do not want to label an entire project (namespace).

When the user deletes the OCP project (namespace), the NAD created in that project is also deleted. When they create a new project (namespace), no NAD as the project is not labeled for sidecar-injection. As a result, the Mesh will fail to resolve the CNI.

Ideally deployments that are labeled for sidecar-injection should be able to reconcile the NAD, similar to how it is done for namespaces today: https://github.com/kumahq/kuma/blob/0976072d8cdbf54502d3c3b2d80c57e0071a14f1/pkg/plugins/runtime/k8s/controllers/namespace_controller.go#L67C18-L67C18

github-actions[bot] commented 11 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 8 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 5 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 2 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.