search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.63k stars 332 forks source link

Apply Entire Directory using kumactl #8491

Open doctorwu opened 10 months ago

doctorwu commented 10 months ago

Description

It would be a useful feature to have the ability to apply all files inside a directory, without having to use fancy shell commands, i.e. xargs, like you can with kubectl.

For example:

kumactl apply -f some-dir/
lplazas commented 10 months ago

Happy to pick this up @jakubdyszkiewicz

lplazas commented 9 months ago

Hey all, I have a first pass implementation ready, but I’d appreciate some thoughts around this: Should we restrict the files we apply to be .yaml or .yml (as I currently do here in the link below)? or should we try to apply every file and ignore if it isn't yaml?

https://github.com/kumahq/kuma/pull/8647/files#diff-1fe08e69b5b0c09a1604645df446a74ccf5123e8f7dd942520155640af802a7eR177

michaelbeaumont commented 9 months ago

@lplazas I'd say we should have the same behavior as kubectl here.

lplazas commented 9 months ago

@lplazas I'd say we should have the same behavior as kubectl here.

I just checked and if a single file is passed to kubectl apply it will read it and try to parse it regardless of the extension. If kubectl apply receives a dir, it will only pick up the files with yaml extension.

github-actions[bot] commented 6 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 3 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 2 weeks ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.