kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.55k stars 326 forks source link

Parametrize stable tags for autoreachableservice Subsets #8522

Open jakubdyszkiewicz opened 7 months ago

jakubdyszkiewicz commented 7 months ago

Description

Feedback from a user on Kuma Slack.

Because supporting all stable (same value) tags between instances of kuma.io/service is expensive to compute, we decided to support only k8s.kuma.io/* tags. However, a user wants to use app.kubernetes.io/name. We could at least allow a user to specify stable tags instead of hardcoding them

var SupportedTags = map[string]struct{}{
    mesh_proto.KubeNamespaceTag: {},
    mesh_proto.KubeServiceTag:   {},
    mesh_proto.KubePortTag:      {},
}

Alternatively, we could try to compute stable tags between instances and between all services.

Context https://kuma-mesh.slack.com/archives/CN2GN4HE1/p1701343313364289

cbugneac-nex commented 7 months ago

Just wanted to second that using K8s labels like app.kubernetes.io/name it's more convenient in our case than Kuma service names - because no need to specify the namespace & port number (with multi-tenancy in K8s cluster). MeshTrafficPermissions for one tenant can be "re-used" for another one - because no need to change the namespace in referenced service name (multiple namespaces).

Also the above label is a K8s known label https://kubernetes.io/docs/reference/labels-annotations-taints/ and recommended in Helm as well https://helm.sh/docs/chart_best_practices/labels/ (de facto standard).

It would be nice to be able to configure additional tags to be used by auto reachable services.

github-actions[bot] commented 4 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

Constantin07 commented 4 months ago

Still need this functionality.

github-actions[bot] commented 1 month ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

Constantin07 commented 1 month ago

Still need this functionality.