kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.55k stars 327 forks source link

Change of mesh in ExternalService doesn't change it's ownerReference #8721

Open lukidzi opened 6 months ago

lukidzi commented 6 months ago

What happened?

  1. Create ExternalService
    apiVersion: kuma.io/v1alpha1
    kind: ExternalService
    mesh: default
    metadata:
    name: httpbin
    spec:
    tags:
    kuma.io/service: httpbin
    kuma.io/protocol: http 
    networking:
    address: httpbin.org:443
  2. Create other mesh with different name
  3. Create the same ExternalService but for other mesh
    apiVersion: kuma.io/v1alpha1
    kind: ExternalService
    mesh: mesh-1
    metadata:
    name: httpbin
    spec:
    tags:
    kuma.io/service: httpbin
    kuma.io/protocol: http 
    networking:
    address: httpbin.org:443
  4. Check the ExternalService object you can notice that ownerReference points to the old mesh image
michaelbeaumont commented 6 months ago

I wonder if we should be setting the owner reference at all? It's not like changing anything on the Mesh results in changes on the ExternalService..

jakubdyszkiewicz commented 6 months ago

Triage: try other policies as well. Check if we have a validation on changing the mesh of the resource.

github-actions[bot] commented 3 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 2 days ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.