search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.66k stars 333 forks source link

Does ConfigMapReconciler need to watch Dataplanes? #8749

Open lobkovilya opened 10 months ago

lobkovilya commented 10 months ago

What happened?

ConfigMapReconciler watches Dataplane resource https://github.com/kumahq/kuma/blob/beb3c363def6e741803285e0ea9d445595b638b8/pkg/plugins/runtime/k8s/controllers/configmap_controller.go#L90

But it's probably unnecessary since DPP inbounds can't be changed without a k8s service change and ConfigMapReconciler already watches services.

jakubdyszkiewicz commented 10 months ago

Triage: to solve this, we need to add a comment why we need to listen on Dataplane. It's because we can add labels (converted to tags) in runtime that are then picked by VirtualOutbounds.

github-actions[bot] commented 7 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 4 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 4 weeks ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.