search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.67k stars 333 forks source link

MeshReconciler doesn't need to call `r.ResourceManager.Delete` because associated resources have ownership #8818

Open lobkovilya opened 10 months ago

lobkovilya commented 10 months ago

Description

https://github.com/kumahq/kuma/blob/be0a0213470d52bd21477c9b5286ce998919b8c3/pkg/plugins/runtime/k8s/controllers/mesh_controller.go#L40-L41

Also, clean up in mesh_manager.go https://github.com/kumahq/kuma/blob/0f0b24d209de0e5203101afc48cb65c3fc1f8939/pkg/core/managers/apis/mesh/mesh_manager.go#L111-L112

github-actions[bot] commented 2 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

jakubdyszkiewicz commented 2 months ago

Triage: First part done. Mesh manager is still todo