search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.67k stars 333 forks source link

Protect against modyfing resources from resource cache #9031

Open jakubdyszkiewicz opened 9 months ago

jakubdyszkiewicz commented 9 months ago

Description

We hit a bug (luckily before a release) that we modify resource meta from ResourceManager and the other place that was reading this went into undefined state.

We could introduce a wrapper over Resource that would panic on calling Set methods just to make sure we don't allow modyfing resources after retrieving them from cached ResourceManager

jakubdyszkiewicz commented 9 months ago

xref https://github.com/kumahq/kuma/issues/8226

github-actions[bot] commented 6 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 3 months ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] commented 4 days ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.