search

kumahq / kuma

🐻 The multi-zone service mesh for containers, Kubernetes and VMs. Built with Envoy. CNCF Sandbox Project.
https://kuma.io/install
Apache License 2.0
3.67k stars 333 forks source link

MeshGatewayInstance's should take a `podTemplateSpec` #9821

Open zskalicky opened 7 months ago

zskalicky commented 7 months ago

What happened?

MeshGatewayInstance has an ability to add metadata and specs for the pods and services it creates (via the podTemplate), however the ability to determine the node/nodes in which will the pod be created is missing.

The podTemplate is missing spec: nodeSelector and spec: affinity

This seems unintentional since the ability to determine where the created mesh gateway pod will be running is important functionality and the ability to alter different values like annotations or labels for the deployment's template for pods is already present.

docs/generated/raw/crds/kuma.io_meshgatewayinstances.yaml

I have asked the community but no one replied. Could you please look into that? Thank you very much.

jakubdyszkiewicz commented 7 months ago

Triage: It makes sense to add it. It's not in the near roadmap, but we are happy to help you contribute. As a workaround you can always deploy your own Deployment+Service instead of using MeshGatewayInstance (see Deployment created by MeshGatewayInstance)

bcollard commented 4 months ago

got the same feedback from one of our customers. Also asking for additional options to expose in the MGI CRD, like securityContext options (runAsUser, runAsGroup) I will let them know it's okay to manage the Mesh GW instances with custom deployments themselves. Is there any drawback to this approach?

github-actions[bot] commented 1 month ago

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.