Closed tuero closed 4 years ago
@tuero Thank you for the PR. I left a comment, let me know what you think. Please note that this repository is a WIP and is undergoing several changes.
I've pushed an updated commit. No worries. I am referencing a project off this repo, and figured I would point out errors that I come across incase others are running into similar issues.
Thank you for the PR!
As it stands, the
get_beta
method is not complete: it is missingepoch
andnum_epoch
arguments. Using the Soenderby beta update method results in a crash. Updating this method would then need to havetrain_model
andvalidate_model
also take inepoch
andnum_epoch
as additional arguments.This pull request adds the above two arguments to train/validate. It also uses the
beta_type
parameter invalidate_model
for consistency instead of using a hardcoded default.