Closed edmorley closed 7 years ago
ok, I guess we need to pin everything in requirements/dev.txt to exact versions, including dependencies, and add --no-deps to the pip args
I meant to add - I'm working on this locally at the moment, so unless I get stuck, I'm happy to fix this :-)
django-nose 1.4.4 dropped support for Django <1.8 and added support for Django 1.10: https://github.com/django-nose/django-nose/blob/master/changelog.rst
As such, if we want to add testing against Django 1.10 it would be much easier if we could just stop testing anything older than Django 1.8.
I know in #20 you wished to retain Django 1.6/1.7 support, however given more time has passed, and given that the only hawkrest users at Mozilla I can find (other than Treeherder, which is using Django 1.10 already) are the not recently maintained: https://github.com/mozilla/apk-signer https://github.com/mozilla/signing-service
...then I think we should just drop Django 1.6/1.7 support now.
The APK signer is no longer in production and not maintained so I'm happy to drop <Django-1.8. We'll just have to remember to put it in the hawkrest changelog. Also, be sure to patch the docs: https://github.com/kumar303/hawkrest/blob/master/docs/index.rst#installation
Thanks for working on this!
I have a branch locally for adding Django 1.10/1.11 to the testing matrix.
However I noticed that even the current testing matrix is currently failing, on fresh pushes of master to my fork. eg:
1) https://travis-ci.org/edmorley/hawkrest/jobs/193424762
(presumably newer django-nose is not compatible with Django 1.6):
2) https://travis-ci.org/edmorley/hawkrest/jobs/193424766
We should first pin these dependencies to make master green, before I make further changes to the testing matrix.
The last (green) Travis run on master was: https://travis-ci.org/kumar303/hawkrest
Comparing the 'py27-django1.8-drf3.3' job to that from my run, shows the following package changes: