kumar303 / hawkrest

Hawk HTTP Authorization for Django Rest Framework
BSD 3-Clause "New" or "Revised" License
19 stars 8 forks source link

Green up Travis tests on master after mohawk and django-nose changes #28

Closed edmorley closed 7 years ago

edmorley commented 7 years ago

1) Improve the assert_log_regex() assertion message Since previously it didn't make expected vs actual clear.

2) Fix tests for changes in mohawk 0.3.3 Several cases that would have previously raised MacMismatch now more correctly raise MisComputedContentHash after kumar303/mohawk#28.

This fixes the test failures seen locally and on Travis, due to the unpinned (as it should be) mohawk dependency in setup.py.

3) Stop testing against Django 1.6/1.7 Since they are no longer supported and there isn't a version of django-nose that supports both Django <1.8 and Django 1.10. There are only two Mozilla properties that are on Django <1.8 that use hawkrest, and neither is actively maintained, so is unlikely to update to newer hawkrest in the future anyway.

To green up Travis it wasn't necessary to pin the dependencies in dev,txt, though that's likely worth doing at some point.

Fixes #27.

My next PR will add testing against newer Django, d-r-f and Python versions.

kumar303 commented 7 years ago

Thanks!