Add `HAWK_USER_LOOKUP` setting to return alternate user models

kumar303 / hawkrest

Hawk HTTP Authorization for Django Rest Framework

BSD 3-Clause "New" or "Revised" License

19 stars 8 forks source link

Add `HAWK_USER_LOOKUP` setting to return alternate user models #34

Closed rneilson closed 7 years ago

rneilson commented 7 years ago

Resolves #3, resolves #35.

Adds HAWK_USER_LOOKUP setting to override user lookup function
- Requires function with signature lookup(request, credentials)
Adds hawk_user_lookup(), hawk_credentials_lookup() methods to HawkAuthentication to allow subclassing instead of using settings
Removes SKIP_HAWK_AUTH setting (as per #35)
Updates tests as required (including using a subclass of HawkAuthentication when testing alternate credential lookup)
Updates documentation, including examples

rneilson commented 7 years ago

@kumar303 Hi Kumar, changes to docs have been made, and I reworked the test to avoid reload_module(). Let me know when you've had a chance to look over the newest version. Thanks!

(I'd request another review, but yours is still open...)

kumar303 commented 7 years ago

I'd request another review, but yours is still open...

The github UI for this is horrendous. Even though it says you've already requested my review, I only get notified if you request a review again 🚀 💥 I'm re-requesting a review so I don't lose track! I should be able to get to it today though.

rneilson commented 7 years ago

@kumar303 (Notification gremlin avoidance attempt)

rneilson commented 7 years ago

You're welcome! Now I can use it in a project of mine. (Better a PR than a fork, y'know?)

kumar303 commented 7 years ago

I just pushed out a new version: https://pypi.python.org/pypi/hawkrest

rneilson commented 7 years ago

Cool, thanks.

Now to figure out the best way to allow (selective) disabling of hash checks, depending on kumar303/mohawk/issues/43...