search

kumar303 / mohawk

Python library for Hawk HTTP authorization
BSD 3-Clause "New" or "Revised" License
47 stars 20 forks source link

PyPI package includes the mohawk tests #18

Closed edmorley closed 9 years ago

edmorley commented 9 years ago

Not urgent at all, but the package on PyPI includes mohawk/tests.py, presumably since setuptools is just collecting everything in the mohawk directory. It accounts for 20KB out of the uncompressed package size of 54KB.

Would tests/tests.py be a better location? :-)

kumar303 commented 9 years ago

I sort of like to distribute tests in the package. That way someone could verify a distributed package if they wanted to. If it were a JavaScript module where small package size is crucial I'd be more concerned about the space. In any case, I don't feel strongly about it so if you'd rather remove tests from the distribution I'd accept a patch for it.

edmorley commented 9 years ago

Makes sense - doesn't bother me too much, just wanted to make sure it was intentional :-)