ZIP compress problem 2.4.5

[GoogleCodeExporter]

1. Enable plugin "compressor"
2. Compress a file

What is the expected output? What do you see instead?
See compressed file. I get "Request failed"

What version of the product are you using? On what operating system?
Mollify 2.4.5 // Centos Linux 6.5 + Php 5.4.25 (complied with zip support)

Please provide any additional information below.
Compress: In web server log (Apache): (--plugin configurated to native or 
ziparchive or raw--)

=========
 PHP Fatal error:  Call to a member function id() on a non-object in ..../backend/include/permissions/PermissionsController.class.php on line 114
=========

Thanks,

PD: please, enable support for tgz, tar.gz, xz (native Linux compressors)

Original issue reported on code.google.com by nicode...@gmail.com on 17 Feb 2014 at 2:01

[GoogleCodeExporter]

Compressor plugin? There is only Archiver plugin that handles both, creating 
and extracting packages, are you talking about the same?

I could not reproduce errors when compressing files with Archiver plugin, if 
you are talking about this plugin, please get the full error log and steps

Original comment by samuli.j...@gmail.com on 17 Feb 2014 at 2:42

[GoogleCodeExporter]

Yes, you right, is Archiver plugin.
The steps are too simple:
1.- Login with a user
2.- Click mouse right on some file (wp-load.php used in this test)
3.- Selected "Comress" in menu
4.- Enter a name for compressed file (pp used in this test)
5.- Get error

Apache mysite_access.log
192.168.1.2 - - [18/Feb/2014:07:52:28 -0300] "POST 
/Admin/backend/r.php/session/authenticate/ HTTP/1.1" 200 1016
192.168.1.2 - - [18/Feb/2014:07:52:28 -0300] "GET 
/Admin/templates/mainview.html?_=1392720862886&_=1392720862886 HTTP/1.1" 304 -
192.168.1.2 - - [18/Feb/2014:07:52:28 -0300] "POST 
/Admin/backend/r.php/filesystem/5301fab3987ea/info/?h=1 HTTP/1.1" 200 3908
192.168.1.2 - - [18/Feb/2014:07:52:40 -0300] "POST 
/Admin/backend/r.php/filesystem/5301fac48db95/details/ HTTP/1.1" 200 310
192.168.1.2 - - [18/Feb/2014:07:52:54 -0300] "POST 
/Admin/backend/r.php/archiver/compress HTTP/1.1" 200 210

Apache mysite_error.log
[Tue Feb 18 07:52:54.818840 2014] [:error] [pid 23791:tid 2854591376] [client 
192.168.1.2:51739] PHP Fatal error:  Call to a member function id() on a 
non-object in ..../backend/include/permissions/PermissionsController.class.php 
on line 114, referer: http://www.mysite.com/Admin/

If I select "Download Compressed" I get the same error.
Decompress upload file, works fine.

Regards,

Original comment by nicode...@gmail.com on 18 Feb 2014 at 11:58

[GoogleCodeExporter]

I have exactly the same problem. It happens not with "Admin"-accounts but with 
"Normal" accounts. Thanks ...

Original comment by oll...@gmail.com on 19 Feb 2014 at 8:36

[GoogleCodeExporter]

#3: That lead me to the real problem, which was in permission handling. It's 
fixed here: 
https://github.com/sjarvela/mollify/commit/5425d3d8f598cb403c0db4bac836fb2e567d6
b7e

I'll release 2.4.6 soon

Original comment by samuli.j...@gmail.com on 19 Feb 2014 at 3:24

• Changed state: Accepted

[GoogleCodeExporter]

Released

Original comment by samuli.j...@gmail.com on 19 Feb 2014 at 3:42

• Changed state: Fixed

[GoogleCodeExporter]

After i update to 2.4.6 no user can log in anymore.
PHP Error Log says:

" MOLLIFY ERROR: ServiceException: INVALID_CONFIGURATION=Error executing query 
(SELECT f.id as id, f.type as type, uf.name as name, f.name as default_name, 
f.path as path FROM mollify_user_folder uf, mollify_folder f, mollify_user u 
WHERE (uf.user_id in (25,8)) AND f.id = uf.folder_id AND u.id = uf.user_id 
ORDER BY u.is_group asc): Unknown column 'f.type' in 'field list' "

And:

" MOLLIFY ERROR: 
{0:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\include\configuration\ConfigurationD
ao.class.php, line:372, function:query, class:MySQLIDatabase, type:->, 
args:{0:SELECT f.id as id, f.type as type, uf.name as name, f.name as 
default_name, f.path as path FROM mollify_user_folder uf, mollify_folder f, 
mollify_user u WHERE (uf.user_id in (25,8)) AND f.id = uf.folder_id AND u.id = 
uf.user_id ORDER BY u.is_group asc}}, 
1:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\include\filesystem\FilesystemControll
er.class.php, line:167, function:getUserFolders, class:ConfigurationDao, 
type:->, args:{0:25, 1:1}}, 
2:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\include\filesystem\FilesystemControll
er.class.php, line:148, function:getFolderDefs, class:FilesystemController, 
type:->, args:{0:}}, 
3:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\include\filesystem\FilesystemControll
er.class.php, line:250, function:getRootFolders, class:FilesystemController, 
type:->, args:{}}, 
4:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\include\services\SessionServices.clas
s.php, line:80, function:getSessionInfo, class:FilesystemController, type:->, 
args:{}}, 
5:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\include\services\SessionServices.clas
s.php, line:61, function:getSessionInfo, class:SessionServices, type:->, 
args:{}}, 
6:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\include\services\SessionServices.clas
s.php, line:50, function:authenticate, class:SessionServices, type:->, 
args:{}}, 
7:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\include\services\ServicesBase.class.p
hp, line:59, function:processPost, class:SessionServices, type:->, args:{}}, 
8:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\include\MollifyBackend.class.php, 
line:85, function:processRequest, class:ServicesBase, type:->, args:{}}, 
9:{file:C:\PATH_TO_MOLLIFY\MOLLIFY\backend\r.php, line:63, 
function:processRequest, class:MollifyBackend, type:->, args:{0:Request}}} "

Did i do something wrong myself perhaps? 

Original comment by Logic...@gmail.com on 20 Feb 2014 at 2:26

[GoogleCodeExporter]

Not exactly related to zip compressing, so let's not continue this here.

But it seems I made a mistake on branching, and db version update was in this 
branch. There is an update 2.4 -> 2.5 that should be run (if the updater does 
not offer it):

UPDATE `{TABLE_PREFIX}parameter` SET value = '2_5' WHERE name = 'version';

ALTER TABLE `{TABLE_PREFIX}folder` ADD `type` char(32) default 'local' NOT NULL 
AFTER `path`;

Original comment by samuli.j...@gmail.com on 20 Feb 2014 at 6:22