kumavis / browserify-commit-sha

:1234: append the latest commit sha to the bundle
MIT License
1 stars 3 forks source link

Replace exec-sync dep with node 0.12 child_process execSync #1

Closed deathcap closed 9 years ago

deathcap commented 9 years ago

The 'exec-sync' module has native dependencies, couldn't get it to easily build on my system (OS X), and https://www.npmjs.com/package/exec-sync 's repository https://github.com/jeremyfa/node-exec-sync says "IMPORTANT: This repository is no longer maintained. For the same feature, use this instead: https://github.com/mgutz/execSync " - but that module is also unmaintained, though it points out an alternative:

Replaced exec-sync in browserify-commit-sha with child_process execSync on node v0.12, works great in my testing. (This does remove browserify-commit-sha compatibility with older node versions like v0.10, if older compatibility is desired this (GPL) module looks like a decent choice: https://www.npmjs.com/package/sync-exec - didn't try it myself though)

kumavis commented 9 years ago

thanks for this by the way, much appreciated.