Closed jorgensd closed 2 months ago
I also see no good motivation to put all the tests inside src/irrevolutions
, as I would rather have them at the root of the repository.
Additionally, I would advice isolating tests inside functions with the prefix test_*
within each test file as several test does not adhere to this principle
Thank you very much for the comments and suggestions.
Tests have been moved to the root, cleaned, isolated within test_* prefixed functions, and the workflow simplified as suggested. All (10) tests pass albeit with several warnings, currently under investigation.
Ref: https://github.com/openjournals/joss-reviews/issues/6897
I cannot get several of the tests to run locally, as i get:
when running the following:
The CI does not yield any outputs of success or not: https://github.com/kumiori/irrevolutions/actions/runs/9664048492/workflow and I would strongly suggest rewriting this to something along the lines of https://github.com/jorgensd/irrevolutions/actions/runs/9879045838/workflow which produces the following trace: https://github.com/jorgensd/irrevolutions/actions/runs/9879045838/job/27284368533