search

kumiori / irrevolutions

Computing Irreversible Evolutions
GNU General Public License v3.0
11 stars 5 forks source link

Reproduce figures from paper #65

Open jorgensd opened 1 month ago

jorgensd commented 1 month ago

What scripts would I have to run to reproduce figures 1-5 in the paper?

This is to comply with

Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.

from https://github.com/openjournals/joss-reviews/issues/6897 Would it be sufficient to run playground/nb/rayleigh_benchmark.ipynb?

Seems like the notebook is a bit outdated, as it uses import eigenspace as eig which should probably be from irrevolutions.utils import eigenspace as eig.

kumiori commented 1 week ago

You can run the JOSS_paper_figures_rayleigh_benchmark.ipynb file, which now correctly includes the package's library.

jorgensd commented 5 days ago

The benchmark seems to depend on some files from the test directory: https://github.com/kumiori/irrevolutions/blob/main/playground/nb/JOSS_paper_figures_rayleigh_benchmark.ipynb?short_path=473f03c#L139-L140 What tests in particular should one run first?:)