search

kumojin / favicon-loader

For retrieving the favicon of a given website and displaying it
MIT License
2 stars 1 forks source link

Add a way to specify a different favicon provider than google #14

Open LukaszKokot opened 3 years ago

LukaszKokot commented 3 years ago

Currently, the getFavicon method does not allow changing the favicon provider, which is google.com by default. This could be changed by adding a second "options" parameter, so that we could call for example:


getFavicon('https://applecom'); // Uses the default google.com/s2/favicons provider
getFavicon('https://applecom', { provider: FAVICON_KIT })

Where FAVICON_KIT would be an enumeration value, along with GOOGLE.

suprabhat15 commented 3 years ago

I want to work on this issue.

LukaszKokot commented 3 years ago

Alright @suprabhat25, here you go, good luck :slightly_smiling_face:

ProgrammingPirates commented 3 years ago

Currently, the getFavicon method does not allow changing the favicon provider, which is google.com by default. This could be changed by adding a second "options" parameter, so that we could call for example:

getFavicon('https://applecom'); // Uses the default google.com/s2/favicons provider getFavicon('https://applecom', { provider: FAVICON_KIT })