search

kumsssss / pe

0 stars 0 forks source link

Tutor has no tag attribute #10

Open kumsssss opened 3 years ago

kumsssss commented 3 years ago

User has no Tag attribute mentioned in the UG but in the DG diagram it is stated the tutor can have as many tags. Screenshot 2021-04-16 at 3.29.23 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Dear responder, thank you for highlighting this issue. To be precise, Tag was an unused attribute of Tutor as previously we had some plans to work around with Tag, but we did not utilize it due to time constraints. Hence, it was completely omitted out in UG as such details shouldn't be shown to the end-users to avoid confusion.

We decided to put it in the DG as it was already implemented but unused since the Developer Guide aims to document the implementations of the various classes, and such details shouldn't be hidden from potential future developers.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for your response. I understand your reason for including tag in your developer guide. However, I feel having this violates one of the principles we have learnt.

image.png

Since no new features were being added in v1.4, that period could have been used to remove the tag attribute which should not take too long since the attribute was not being used in any features mentioned by you.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]