search

kumuluz / kumuluzee

Lightweight open-source framework for developing microservices using standard Java EE technologies and migrating Java EE to cloud-native architecture.
https://ee.kumuluz.com
MIT License
291 stars 71 forks source link

Config override using -D changed in 3.12? #193

Closed danpfe closed 3 years ago

danpfe commented 3 years ago

Hi,

recently upgraded to 3.12 and wonder if I stumbled over a regression or if the change was intentional.

I have a embedded config.yaml on the classpath and sometimes I want to override a "default value" using -D, such as kumuluzee.server.http.port.

In 3.12, when the value is already present in config.yaml, the -Dkumuluzee.server.http.port=18080 has no effect, but did so in previous versions. However, if i remove the entry from the config.yaml then -D does work.

Thanks, Daniel

danpfe commented 3 years ago

Previously used v3.10 and checked v3.11. It seems the "regression" is already present in 3.11. So works on 3.10, changed on 3.11.

MBJuric commented 3 years ago

Hi Daniel, We will have a look at it shortly. Thanks, Matjaz

urbim commented 3 years ago

This is definitely a regression. I will have the fix ready shortly. Thanks for reporting this.

urbim commented 3 years ago

Should be fixed in 3.12.1.