search

kunalb / poet

An emacs theme that's well suited for modes using variable pitch: particularly org-mode and markdown-mode.
MIT License
515 stars 15 forks source link

Custom heights bring too many isssues #23

Open ujikol opened 3 years ago

ujikol commented 3 years ago

I like the theme a lot, But the implementation of the different heights brings too many troubles for me:

  1. text-scale-adjust ignores at least all headings
  2. misalignment in agenda caused by tags
  3. other misalignment in column views
  4. ...

Is there a way to just use default behavior for heights?

And then I will also disable variable-pitch to avoid further misalignment. What's the best way to set fixed-pitch for all with Iosevka font?

Thanks

kunalb commented 3 years ago

Disabling variable pitch should make everything fixed-pitch and flat.

For setting heights to be fixed, customizing poet-theme-variable-headers to nil should make everything equally sized/disable the different heights, but I'm not sure if that will make text-scale-adjust behave smoothly.

In the worst case you can directly edit the theme to simply remove all height customization; I'll think about making that an explicit option.

ujikol commented 3 years ago

(setq poet-theme-variable-headers nil) does not enable the scaling of headings.

I also tried (custom-theme-set-faces 'poet (org-level-1 ((t (:inherit default :foreground "#e0e0e0" :height 98))))) (set-face-attribute 'org-level-2 t :height 98) ` Neither worked.

Other ideas?

ujikol commented 3 years ago

The height of the face is changed when i put the set-face-attribute in the text-mode-hook.

But again there is no scaling of the headings.

tangxinfa commented 3 years ago

Disable custom heights:

(advice-add 'poet-theme--height :around (lambda (orig-fun multiplier)
    (face-attribute 'default :height)))
kmgolden commented 3 years ago

@tangxinfa this worked for me. Thank you! @kunalb maybe add this to the Readme for resolution?